feat(ISV-6377): let cosign use HashedRekord for TLOG verification of attestations #4490
+327
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attestations Assisted-by: calude-4.5-sonnet (Cursor) Signed-off-by: Marek Szymutko <[email protected]>
Contributor
|
@steiza, fya as I mentioned this to you on a call a couple weeks back. |
Contributor
|
Hey y'all, sorry to leave this PR hanging. I will get back to it in a week or so. The approach seems reasonable, but I need to dedicate a bit of time to think through this and if there's any unintended consequences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assisted-by: claude-4.5-sonnet (Cursor)
Signed-off-by: Marek Szymutko [email protected]
Addresses the verification part of #3599
Summary
Without this feature, the hashedRekords cannot be used as TLOG entries for attestations because the
cosign verify-attestationwould fail. The problem is described in #3599 but the brief summary is:cosign attestuses DSSE or in-toto payloads, sends the whole payload to the Rekor servercosign verify-attestationnow also supports HashedRekord TLOG entries, which makes sure that a digest is sufficient payload to be uploaded to Rekor.cosign attestdoesn't support uploading the HashedRekord entries. A workaround must be used as of now, the workaround is described in this write-up (with the only difference that when using the version of Cosign built from this PR, the verification succeeds)Release Note
cosign verify-attestationDocumentation
No user-facing API was changed in this PR, I believe comments in code are a sufficient change.